Update to Zephyr v4.3.0 #10716
Update to Zephyr v4.3.0 #10716
Conversation
|
FYI I'm working through the CI build issues and will rebase once I figure it out and then request a review. |
tannewt
force-pushed
the
zephyr-v4.3.0
branch
from
1498cf0 to
172b918
Compare
tannewt
force-pushed
the
zephyr-v4.3.0
branch
from
172b918 to
70a3af8
Compare
|
Finally got this all sorted. It is ready for review. |
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks for your persistence!
| circuitpython_flags.append(f"-DCIRCUITPY_FULL_BUILD={1 if full_build else 0}") | ||
| circuitpython_flags.append(f"-DCIRCUITPY_USB_HOST={1 if usb_host else 0}") | ||
| circuitpython_flags.append(f'-DCIRCUITPY_BOARD_ID=\\"{board}\\"') | ||
| circuitpython_flags.append(f"-DCIRCUITPY_BOARD_ID='\"{board}\"'") |
There was a problem hiding this comment.
This looks good to me. I am just curious. Why doesn't
circuitpython_flags.append(f"-DCIRCUITPY_BOARD_ID={board}")work here, since we know the board has no spaces? Does the context in which this is used require a double-quoted argument?
Similarly elsewhere below, where there are filenames in quotes, etc.
There was a problem hiding this comment.
The filenames are used in #include lines and need the quotes. This needs them to be a c-string:
I changed it to wrapped in single quotes because the response file will escape the backspace formerly used to escape the double quote.
2 participants
Shouldn't change functionality at all.
Smoke tested on the nRF52840 DK.